Added a guide & sample for a custom logger client implementation. #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Djcarrillo6 <[email protected]> Black formatter Signed-off-by: Djcarrillo6 <[email protected]>
Djcarrillo6
requested review from
VachaShah,
dblock,
harshavamsi,
axeoman,
deztructor,
Shephalimittal,
saimedhi and
florianvazelle
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #579 +/- ##
=======================================
Coverage 71.98% 71.98%
=======================================
Files 89 89
Lines 7935 7935
=======================================
Hits 5712 5712
Misses 2223 2223 ☔ View full report in Codecov by Sentry. |
dblock
reviewed
Nov 13, 2023
…logs-metrics-collecton-script
Djcarrillo6
force-pushed
the
proposal/issue-331/logs-metrics-collecton-script
branch
from
8556334 to
9ce310a
Compare
|
Hey @dblock @saimedhi I am getting this failure error in the Ci/lint job here. I tried running the black formatter on the file with |
|
@Djcarrillo6 you should run |
Djcarrillo6
force-pushed
the
proposal/issue-331/logs-metrics-collecton-script
branch
from
9ce310a to
cdaa55b
Compare
Djcarrillo6
force-pushed
the
proposal/issue-331/logs-metrics-collecton-script
branch
2 times, most recently
from
7c295b5 to
3ece675
Compare
Signed-off-by: Djcarrillo6 <[email protected]> Fixed import formatting in sample code for gudie. Signed-off-by: Djcarrillo6 <[email protected]> Fixed nox formatting of log collection sample module. Signed-off-by: Djcarrillo6 <[email protected]> Added types to log_collection_sample.py Signed-off-by: Djcarrillo6 <[email protected]> Added type ignore to StramHandler class Signed-off-by: Djcarrillo6 <[email protected]> Added formatting change Signed-off-by: Djcarrillo6 <[email protected]>
Djcarrillo6
force-pushed
the
proposal/issue-331/logs-metrics-collecton-script
branch
from
3ece675 to
18373d1
Compare
…logs-metrics-collecton-script
dblock
requested changes
Nov 19, 2023
dblock
reviewed
Nov 19, 2023
saimedhi
reviewed
Nov 20, 2023
Djcarrillo6
force-pushed
the
proposal/issue-331/logs-metrics-collecton-script
branch
from
bf18089 to
5e82fa0
Compare
Djcarrillo6
force-pushed
the
proposal/issue-331/logs-metrics-collecton-script
branch
2 times, most recently
from
6e1a562 to
04b82ea
Compare
dblock
requested changes
Nov 21, 2023
Signed-off-by: Djcarrillo6 <[email protected]> Fixed typo in CHANGELOG. Signed-off-by: Djcarrillo6 <[email protected]> Requested changes. Signed-off-by: Djcarrillo6 <[email protected]> Requested changes again. Signed-off-by: Djcarrillo6 <[email protected]> Added link in USER_GUIDE.md. Signed-off-by: Djcarrillo6 <[email protected]>
Djcarrillo6
force-pushed
the
proposal/issue-331/logs-metrics-collecton-script
branch
from
04b82ea to
580e2c2
Compare
…logs-metrics-collecton-script
saimedhi
approved these changes
Nov 21, 2023
dblock
approved these changes
Nov 22, 2023
roma2023
pushed a commit
to roma2023/opensearch-py
that referenced
this pull request
Dec 28, 2023
…ensearch-project#579) * Added a guide & sample for a custom logger client implementation. Signed-off-by: Djcarrillo6 <[email protected]> Black formatter Signed-off-by: Djcarrillo6 <[email protected]> * Changes from PR review Signed-off-by: Djcarrillo6 <[email protected]> Fixed import formatting in sample code for gudie. Signed-off-by: Djcarrillo6 <[email protected]> Fixed nox formatting of log collection sample module. Signed-off-by: Djcarrillo6 <[email protected]> Added types to log_collection_sample.py Signed-off-by: Djcarrillo6 <[email protected]> Added type ignore to StramHandler class Signed-off-by: Djcarrillo6 <[email protected]> Added formatting change Signed-off-by: Djcarrillo6 <[email protected]> * Added PR review changes. Signed-off-by: Djcarrillo6 <[email protected]> Fixed typo in CHANGELOG. Signed-off-by: Djcarrillo6 <[email protected]> Requested changes. Signed-off-by: Djcarrillo6 <[email protected]> Requested changes again. Signed-off-by: Djcarrillo6 <[email protected]> Added link in USER_GUIDE.md. Signed-off-by: Djcarrillo6 <[email protected]> --------- Signed-off-by: Djcarrillo6 <[email protected]> Signed-off-by: roma2023 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Black formatter
Description
Issues Resolved
Resolve proposal related to issue #331
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.